Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible missing null check #12

Closed
mmrath opened this issue Aug 15, 2020 · 2 comments
Closed

Possible missing null check #12

mmrath opened this issue Aug 15, 2020 · 2 comments
Assignees
@mefechoel
Labels
bug Something isn't working

Comments

@mmrath
Copy link

mmrath commented Aug 15, 2020

Describe the bug

actions.js:55 Uncaught TypeError: Cannot read property 'hasAttribute' of null
    at actions.js:55
    at HTMLDivElement.handleClick (actions.js:12)

svelte-navigator/src/actions.js

Line 55 in 6562b61

if (!anchor.hasAttribute("noroute")) {

To Reproduce
Steps to reproduce the behaviour:

  1. Use use:links on the top level element
  2. Click on anywhere on the page that is not a child of an anchor <a> element
@mefechoel mefechoel added the bug Something isn't working label Aug 15, 2020
@mefechoel
Copy link
Owner

Good catch, thanks for submitting!

mefechoel added a commit that referenced this issue Aug 15, 2020
@mefechoel
#12 Check if anchor is null when using use:links
cd4892a
@mefechoel
Copy link
Owner

Fixed in 3.0.11

@mefechoel mefechoel self-assigned this Aug 15, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mefechoel mefechoel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmrath @mefechoel