add feature 'enable_db_speed_record' #12

xudaquan2003 · 2023-10-23T07:10:12Z

add feature 'enable_db_speed_record'

anonymousGiga · 2023-10-24T00:51:47Z

bin/reth/Cargo.toml

+    "reth-provider/enable_opcode_metrics",
+    "reth-stages/enable_db_speed_record",
+    "open_performance_dashboard",
+]


Why does enable_db_speed_record rely on other features？

anonymousGiga · 2023-10-24T00:52:38Z

crates/primitives/src/log.rs

+#[cfg(feature = "enable_db_speed_record")]
+impl Log {
+    /// Calculate size of the [Log].
+    #[cfg(feature = "enable_db_speed_record")]


Only one #[cfg(feature = "enable_db_speed_record")] is needed here

anonymousGiga · 2023-10-24T00:56:12Z

crates/stages/src/metrics/listener.rs

@@ -163,7 +193,7 @@ impl Future for MetricsListener {
        loop {
            let Some(event) = ready!(this.events_rx.poll_recv(cx)) else {
                // Channel has closed
-                return Poll::Ready(())
+                return Poll::Ready(());
            };


Should format the code.

anonymousGiga · 2023-10-24T01:03:15Z

crates/stages/src/stages/execution.rs

+            db_speed_record.write_to_db_size = u64::try_from(state.size()).unwrap();
+        }
+        #[cfg(feature = "enable_db_speed_record")]
+        let mut write_to_db_time = revm_utils::time::TimeRecorder::now();


Use mininstant get time.

anonymousGiga · 2023-10-24T01:03:57Z

crates/stages/src/stages/execution.rs

-        if !(max_block - start_block > self.external_clean_threshold ||
-            provider.tx_ref().entries::<tables::AccountsTrie>()?.is_zero())
+        if !(max_block - start_block > self.external_clean_threshold
+            || provider.tx_ref().entries::<tables::AccountsTrie>()?.is_zero())


Format the code.

anonymousGiga · 2023-10-24T01:05:51Z

crates/storage/provider/Cargo.toml

+enable_db_speed_record = [
+    "revm-utils",
+    "reth-revm-primitives/enable_opcode_metrics",


A should not rely on other features

anonymousGiga · 2023-10-24T01:11:31Z

crates/storage/provider/src/test_utils/mock.rs

+    fn header_by_number_with_db_info(&self, num: BlockNumber) -> Result<(Option<Header>, u64, u64)> {
+        let lock = self.headers.lock();
+        Ok((lock.values().find(|h| h.number == num).cloned(), 0, 0))
+    }


#[cfg(feature = "enable_db_speed_record")] fn header_by_number_with_db_info(&self, num: BlockNumber) -> (Result<Option<Header>>, u64, u64) { (self.header(number), 0, 0) }

anonymousGiga · 2023-10-24T01:12:07Z

crates/storage/provider/src/test_utils/mock.rs

+            .fold(U256::ZERO, |td, h| td + h.difficulty);
+        Ok((Some(sum), 0, 0))
+    }
+


Same as above

anonymousGiga · 2023-10-25T03:34:04Z

crates/stages/src/stages/execution.rs

@@ -234,11 +266,42 @@ impl<EF: ExecutorFactory> ExecutionStage<EF> {
        // Write remaining changes
        trace!(target: "sync::stages::execution", accounts = state.accounts().len(), "Writing updated state to database");
        let start = Instant::now();
+
+        #[cfg(feature = "enable_db_speed_record")]
+        {


update update update update add finish_after_execution_stage feature for reth node update revm update log for revm metric some update for performance-dashboard update for write_to_db log Split the get_revm_metric_record function into two add feature 'enable_execution_duration_record' (#6) * add feature 'enable_execution_duration_record' * set 'enable_execution_duration_record' feature for util mod refactor: refactoring the code of get revm metric (#8) Refactor: refactoring the code of get cachedb metric (#9) add feature 'enable_tps_gas_record' (#7) * add feature 'enable_tps_gas_record' * format and rebase code --------- Co-authored-by: anonymousGiga <cryptonymGong@gmail.com> use minstant instead of TimeRecord (#10) update for revm dependencies (#11) Enable sload percentiles (#14) support test oom th (#15) add feature 'enable_db_speed_record' (#12) * add feature 'enable_db_speed_record' * Some minor refactoring --------- Co-authored-by: anonymousGiga <cryptonymGong@gmail.com> update revm dependencies for opcode gas metric (#16) update revm dependencies refactor opcode metric (#17) close some log update dependencies update revm dependencies refactor performance dashboard (#19) * support performance dashboard * delete obsolete code --------- Co-authored-by: anonymousGiga <cryptonymGong@gmail.com> add sload duration percentile print

update update update update add finish_after_execution_stage feature for reth node update revm update log for revm metric some update for performance-dashboard update for write_to_db log Split the get_revm_metric_record function into two add feature 'enable_execution_duration_record' (#6) * add feature 'enable_execution_duration_record' * set 'enable_execution_duration_record' feature for util mod refactor: refactoring the code of get revm metric (#8) Refactor: refactoring the code of get cachedb metric (#9) add feature 'enable_tps_gas_record' (#7) * add feature 'enable_tps_gas_record' * format and rebase code --------- Co-authored-by: anonymousGiga <cryptonymGong@gmail.com> use minstant instead of TimeRecord (#10) update for revm dependencies (#11) Enable sload percentiles (#14) support test oom th (#15) add feature 'enable_db_speed_record' (#12) * add feature 'enable_db_speed_record' * Some minor refactoring --------- Co-authored-by: anonymousGiga <cryptonymGong@gmail.com> update revm dependencies for opcode gas metric (#16) update revm dependencies refactor opcode metric (#17) close some log update dependencies update revm dependencies refactor performance dashboard (#19) * support performance dashboard * delete obsolete code --------- Co-authored-by: anonymousGiga <cryptonymGong@gmail.com> add sload duration percentile print modify cargo default config add enable_opcode_metrics feature in EVMProcessor fix bug of caculate total_duration

anonymousGiga reviewed Oct 24, 2023

View reviewed changes

xudaquan2003 force-pushed the xudq/debug/enable_db_speed_record branch from ad7ed9a to 4adc66c Compare October 24, 2023 08:59

add feature 'enable_db_speed_record'

126b3f2

xudaquan2003 force-pushed the xudq/debug/enable_db_speed_record branch from 4adc66c to 126b3f2 Compare October 24, 2023 10:34

anonymousGiga reviewed Oct 25, 2023

View reviewed changes

Some minor refactoring

7c5fef5

anonymousGiga merged commit e007b1a into andy/debug/performance-dashboard Oct 25, 2023
5 of 17 checks passed

anonymousGiga deleted the xudq/debug/enable_db_speed_record branch October 25, 2023 03:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add feature 'enable_db_speed_record' #12

add feature 'enable_db_speed_record' #12

xudaquan2003 commented Oct 23, 2023

anonymousGiga Oct 24, 2023

anonymousGiga Oct 24, 2023

anonymousGiga Oct 24, 2023

anonymousGiga Oct 24, 2023

anonymousGiga Oct 24, 2023

anonymousGiga Oct 24, 2023

anonymousGiga Oct 24, 2023

anonymousGiga Oct 24, 2023

anonymousGiga Oct 25, 2023

add feature 'enable_db_speed_record' #12

add feature 'enable_db_speed_record' #12

Conversation

xudaquan2003 commented Oct 23, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment