fix: charges/duration parsing #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just tried the client on 13.17 and the flags for charges/duration were not passed properly. This seems to resolve that problem.
dudantas
pushed a commit
that referenced
this pull request
Nov 17, 2023
… 12.80) (#543) Implementation of the Forge New features: • Added talkactions for use in forge system; Talkactions "/adddusts, /removedusts, /getdusts, /setdusts" Talkaction to teleport to fiendish creature "/fiendish" and for influenced "/influenced" Talkaction to set monster fiendish "/setfiendish", need to look to monster direction and use talkaction Added in "/m" talkaction the param for create monster fiendish/influenced, example: "/m rat, 1" create an influenced Rat with level 1 (allowed is 1-5) "/m rat, fiendish" create a Rat with fiendish status Talkaction to open forge "/openforge" • Added spell to find fiendish "exiva moe res" NOTE: The system is, as far as possible, the same as the global one, there is still a lot of information about the system that nobody knows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Game screen breaks when playing with newest client.
Just tried the client with 13.17 and the flags for charges/duration were not passed properly. This seems to resolve that problem, though this may require testing to make sure it doesn't break anything on other versions.
Behaviour
Actual
game screen is breaking like crazy when you run into a might ring, inventory fails to load
Expected
smooth performance as usual
Fixes
no issue to tag, some people possibly reported this on OTC Redemption discord
Type of change
Please delete options that are not relevant.
How Has This Been Tested
I ran my server in "safe mode" - sending only packets required to login and walk.
Test Configuration:
before (the packet parsing was breaking on might ring which has "wearout" flag):
after (I ran my server in "normal mode", the client is able to load both the might ring and my inventory now):
Checklist