Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: botserver updates #722

Merged
merged 2 commits into from
Mar 11, 2024
Merged

fix: botserver updates #722

merged 2 commits into from
Mar 11, 2024

Conversation

Nottinghster
Copy link
Collaborator

  • Fix crash
  • isConnected()
  • hasListen()
  • resetReconnect()

@credits: Leesneaks/otclientv8@c72fdb5

+ Fix crash
+ isConnected()
+ hasListen()
+ resetReconnect()
@ericcobblepot
Copy link

ericcobblepot commented Mar 10, 2024

does mehah have botserver?

@Nottinghster

@Nottinghster
Copy link
Collaborator Author

does mehah have botserver?

@Nottinghster

Well, since it's the same from v8, every fix there, should be here too ;)

image

@ericcobblepot
Copy link

ericcobblepot commented Mar 10, 2024

does mehah have botserver?
@Nottinghster

Well, since it's the same from v8, every fix there, should be here too ;)

I understand about fixing bugs, but why activate something that doesn't work (currently) ?

@Nottinghster
Copy link
Collaborator Author

does mehah have botserver?
@Nottinghster

Well, since it's the same from v8, every fix there, should be here too ;)

I understand about fixing bugs, but why activate something that doesn't work (currently) ?

Because people can host their own bot servers and connect to those instead

@Nottinghster Nottinghster changed the title BotServer updates fix: botserver updates Mar 10, 2024
@Nottinghster
Copy link
Collaborator Author

@ericcobblepot

If you want to know why, here's the reason: https://discord.com/channels/965178465915633674/1216070153763295342

@ericcobblepot
Copy link

ericcobblepot commented Mar 10, 2024

Because people can host their own bot servers and connect to those instead

at least you testified it? @Nottinghster

OTClient Redemption:

image

ERROR: WebsocketSession error WebsocketSession unable to on_write ws://127.0.0.1:5000/send: The provided file handle is not valid.

vs

v8

image

if does not work, why do you activate it here? _Loader.lua

@Nottinghster
Copy link
Collaborator Author

Because people can host their own bot servers and connect to those instead

at least you testified it? @Nottinghster

OTClient Redemption:

image

ERROR: WebsocketSession error WebsocketSession unable to on_write ws://127.0.0.1:5000/send: The provided file handle is not valid.

vs

v8

image

if does not work, why do you activate it here? _Loader.lua

I've deactivated again, it was a mistake...
But glad you've tested, personally, I don't use bot, but as I said before, the PR is created, if someone find bugs, create another PR fixing it, simple like that

@mehah mehah merged commit 5409074 into mehah:main Mar 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants