Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: shop system #888

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

improve: shop system #888

wants to merge 28 commits into from

Conversation

Nottinghster
Copy link
Collaborator

Credits: oen44

What I've changed:

  • Renamed Store to Shop
  • Compatible with ZNOTE AAC (easy to modify)

Preview:

image

image

@Wirless
Copy link

Wirless commented Sep 30, 2024

shaders.zip
add shaders n stuff credits :oen xD

@gesior
Copy link

gesior commented Nov 27, 2024

Did anyone benchmark server side of that system?

I know OTS owners who added OTCv8 Game Store for old protocol (also uses extendedJSON opcodes), added 300-500 offers and every time someone opened Game Store, it lagged server for 0.1 sec (confirmed using OTS Stats).
Most of time takes encoding Lua offer table into JSON (~100 KB with URLs to images etc.).

"Tibia Protocol" Game Store fixes this problem in 2 ways:

  • uses binary format for data (no JSON encoding)
  • loads only offers from selected category, not all categories (much less data to load)

Copy link

sonarcloud bot commented Nov 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants