Add context::Builder #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehcode
requested changes
Sep 15, 2017
lib/src/context/builder.rs
Outdated
| } | ||
|
|
||
| /// Set an header | ||
| pub fn set_header<H: Header>(mut self, value: H) -> Self { |
There was a problem hiding this comment.
Methods on a builder should be just header and not set_header. See a similar method on http::request::Builder: https://docs.rs/http/0.1.0/http/request/struct.Builder.html#method.header
lib/src/context/builder.rs
Outdated
| } | ||
|
|
||
| /// Set the request data | ||
| pub fn set_data<B: Into<Body>>(mut self, body: B) -> Self { |
lib/src/request/builder.rs
Outdated
| } | ||
|
|
||
| /// Create the `Context`, returning any error that occurs during build. | ||
| pub fn finalize(self) -> Result<Request, error::UriError> { |
There was a problem hiding this comment.
This should probably be Result<Request, shio::Error> so we don't expose the hyper error type.
|
Awesome job again and appreciate the fixes @Meralis40. Really busy this week so not sure when I'll have time to wrap this up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
context::Builder, a helper struct for creating aContext.Also modify
Routertests to use the newBuilder.Closes #22