Allow environment URL to be overridden by a local environment variable #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a cool addition to customize the preview URL. However, we need to grab the env variable from the ForgeSetting in order to use it. Feel free to add it at your convenience. If you find yourself short on time, don't hesitate to reach out - I'd be more than happy to assist with the addition. |
|
@mehrancodes I think I have the PR updated correctly. I can't test it correctly right now though as my environment is getting a timeout on deployment (looks like Laravel Mix is taking too long to run). Could you check this PR? |
mehrancodes
approved these changes
Mar 1, 2024
|
I gave it a manual test - everything works smoothly. Thank you for the updates, and the new feature! I would tag a new release for it today 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Improvement
Allows the environment URL that is published as part of the GitHub comment to be overridden with a local environment variable.
Use Case
In my app, I want to sent the QA team to a subdomain of the environment. Going to the bare domain the site is launched on actually doesn't return the app (by design). With this fix, I could put the URL, including subdomain, into the GitHub comment.
Implementation
Adds a FORGE_ENVIRONMENT_URL environment variable that overrides the environment URL for the forge site.