Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal]Handling zero or negative. #102

Closed
meian opened this issue Feb 7, 2022 · 1 comment · Fixed by #103
Closed

[Proposal]Handling zero or negative. #102

meian opened this issue Feb 7, 2022 · 1 comment · Fixed by #103
Assignees
@meian
Labels
breaking changes Has breaking changes improvement Some improvement

Comments

@meian
Copy link
Owner

meian commented Feb 7, 2022 •
edited
Loading

Proposal.

Like strings.Repeat, change so func ends with panic by invalid zero or negative arguments.

Breaking change targets are below.

  • panic by negative num
    • Repeat
    • RepeatIterable
    • Take
    • TakeLast
    • Skip
    • SkipLast
  • panic by zero
    • Range
      • change interface with no error.

What benefit with the proposal?

Understand easily for arguments ristriction and can approach to golang standard.

Others

strings.Repeat
@meian meian added improvement Some improvement breaking changes Has breaking changes labels Feb 7, 2022
@meian meian changed the title [wip][Proposal]Handling zero or negative. [Proposal]Handling zero or negative. Feb 8, 2022
@meian meian mentioned this issue Feb 8, 2022
Merged
3 tasks
@meian meian self-assigned this Feb 8, 2022
meian added a commit that referenced this issue Feb 8, 2022
@meian
#102 Change Range then raises panic if step == 0
60ffc9f
meian added a commit that referenced this issue Feb 8, 2022
@meian
#102 Change Repeat raises panic if count < 0
37f2aa1
meian added a commit that referenced this issue Feb 8, 2022
@meian
#102 Change Take raises panic if count < 0
53cd9a6
meian added a commit that referenced this issue Feb 8, 2022
@meian
#102 Change TakeLast raises panic if count < 0
58d1071
meian added a commit that referenced this issue Feb 8, 2022
@meian
#102 Change Skip raises panic if count < 0
f606ccf
meian added a commit that referenced this issue Feb 8, 2022
@meian
#102 Change SkipLast raises panic if count < 0
35da4ef
meian added a commit that referenced this issue Feb 8, 2022
@meian
#102 Change Range then raises panic if step == 0
a2d913c
meian added a commit that referenced this issue Feb 8, 2022
@meian
#102 Change Repeat raises panic if count < 0
cac8d94
meian added a commit that referenced this issue Feb 8, 2022
@meian
#102 Change Take raises panic if count < 0
c819bfb
meian added a commit that referenced this issue Feb 8, 2022
@meian
#102 Change TakeLast raises panic if count < 0
e75745b
meian added a commit that referenced this issue Feb 8, 2022
@meian
#102 Change Skip raises panic if count < 0
9426ee3
meian added a commit that referenced this issue Feb 8, 2022
@meian
#102 Change SkipLast raises panic if count < 0
92c7aa5
meian added a commit that referenced this issue Feb 8, 2022
@meian
#102 Change Repeat raises panic if count < 0
8322eaa
meian added a commit that referenced this issue Feb 8, 2022
@meian
#102 Change Take raises panic if count < 0
9965c39
meian added a commit that referenced this issue Feb 8, 2022
@meian
#102 Change TakeLast raises panic if count < 0
22d805a
meian added a commit that referenced this issue Feb 8, 2022
@meian
#102 Change Skip raises panic if count < 0
c7abc80
meian added a commit that referenced this issue Feb 8, 2022
@meian
#102 Change SkipLast raises panic if count < 0
ab9a39b
meian added a commit that referenced this issue Feb 8, 2022
@meian
#102 Change Repeat raises panic if count < 0
628683a
meian added a commit that referenced this issue Feb 8, 2022
@meian
#102 Change Take raises panic if count < 0
a2bab97
meian added a commit that referenced this issue Feb 8, 2022
@meian
#102 Change TakeLast raises panic if count < 0
fcc404a
meian added a commit that referenced this issue Feb 8, 2022
@meian
#102 Change Skip raises panic if count < 0
64a2466
meian added a commit that referenced this issue Feb 8, 2022
@meian
#102 Change SkipLast raises panic if count < 0
89ec5c0
@meian
Copy link
Owner Author

meian commented Feb 8, 2022

#103 (comment)
ゼロ値でパニック起こさせるのは危なさそうなのでRangeの修正は止めた

@meian meian closed this as completed in #103 Feb 8, 2022
meian added a commit that referenced this issue Feb 8, 2022
@meian
Merge pull request #103 from meian/102-handling-zero-or-negative
082c567 
#102 Handling zero or negative.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meian meian

Labels
breaking changes Has breaking changes improvement Some improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#102 Handling zero or negative. meian/gcf
1 participant
@meian