Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal]Apply linter on CI #96

Closed
meian opened this issue Feb 7, 2022 · 0 comments · Fixed by #111
Closed

[Proposal]Apply linter on CI #96

meian opened this issue Feb 7, 2022 · 0 comments · Fixed by #111
Labels
environment For environment improvement Some improvement

Comments

@meian
Copy link
Owner

meian commented Feb 7, 2022

Proposal.

Add linter CI.
As a candidate, https://github.com/reviewdog/action-golangci-lint

What benefit with the proposal?

Process static review on CI.

Others

Originally posted by @meian in #3 (comment)
@meian meian added improvement Some improvement environment For environment labels Feb 7, 2022
@meian meian mentioned this issue Feb 7, 2022
Closed
@meian meian mentioned this issue Mar 21, 2022
Merged
3 tasks
meian added a commit that referenced this issue Mar 21, 2022
@meian
#96 Add lint github action
5549d51
meian added a commit that referenced this issue Mar 21, 2022
@meian
fixup! #96 Add lint github action
ebbfcda
meian added a commit that referenced this issue Sep 7, 2022
@meian
#96 Add lint github action
9243738
meian added a commit that referenced this issue Sep 7, 2022
@meian
fixup! #96 Add lint github action
9ab5fd4
meian added a commit that referenced this issue Sep 8, 2022
@meian
#96 Add lint github action
fae94d1
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Add lint github action
36503f2
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Add lint github action
6fa1076
meian added a commit that referenced this issue Sep 8, 2022
@meian
#96 Fix for warnings
fd44a3a
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Add lint github action
75debac
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Add lint github action
d9050da
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Add lint github action
3fae5f7
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Add lint github action
bd5d8b4
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Add lint github action
a4a4353
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Add lint github action
fab0d18
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Add lint github action
0ef605d
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Add lint github action
35472f7
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Add lint github action
dc11c51
meian added a commit that referenced this issue Sep 8, 2022
@meian
#96 Fix for warnings
b2283e7
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Add lint github action
552b16b
meian added a commit that referenced this issue Sep 8, 2022
@meian
#96 Add lint github action
8dc5894
meian added a commit that referenced this issue Sep 8, 2022
@meian
#96 Fix for warnings
966bd07
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Add lint github action
be9ffaa
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Add lint github action
2287124
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Add lint github action
60cc9f1
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Fix for warnings
d24238f
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Fix for warnings
044fe34
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Fix for warnings
ee7b907
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Add lint github action
8ef5294
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Add lint github action
7404269
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Fix for warnings
44f3694
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Fix for warnings
f88028e
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Add lint github action
a7f9130
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Add lint github action
8002ae0
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Fix for warnings
3b0e8b1
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Add lint github action
41920ef
meian added a commit that referenced this issue Sep 8, 2022
@meian
fixup! #96 Add lint github action
2338717
meian added a commit that referenced this issue Sep 8, 2022
@meian
#96 Add lint github action
29f0930
meian added a commit that referenced this issue Sep 8, 2022
@meian
#96 Fix for warnings
e2d41ea
meian added a commit that referenced this issue Sep 8, 2022
@meian
#96 Fix for warnings
9c2eb36
@meian meian closed this as completed in #111 Sep 8, 2022
meian added a commit that referenced this issue Sep 8, 2022
@meian
Merge pull request #111 from meian/96-apply-linter-on-ci
248a3de 
#96 Apply linter on CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
environment For environment improvement Some improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#96 Apply linter on CI meian/gcf
1 participant
@meian