Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #33

Merged
merged 4 commits into from
Jan 18, 2022
Merged

Refactoring #33

merged 4 commits into from
Jan 18, 2022

Conversation

meian
Copy link
Owner

@meian meian commented Jan 18, 2022

それぞれの関数処理でラップしない方が処理の負荷がなくなりそうだったので諸々調整

  • Map
    • 内部変数を見やすいようにした
    • inputのIterableがnilの場合は空のIterableを返すようにした
  • Filter
    • inputのIterableがnilの場合は空のIterableを返すようにした
    • 条件がnilの場合は元のIterableを返すようにした
  • Concat
    • inputの両方がnilの場合は空のIterableを返すようにした
    • inputのいずれかがnilの場合はnilでないIterableを返すようにした

@meian meian added the refactoring Clean source code or structures label Jan 18, 2022
@meian meian self-assigned this Jan 18, 2022
@meian
Copy link
Owner Author

meian commented Jan 18, 2022

テスト内容は変更しないでカバレッジも変わってないので問題なさそう

@meian meian merged commit 228a540 into main Jan 18, 2022
@meian meian deleted the refactor branch January 18, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Clean source code or structures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant