Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#84 Last to TakeLast #85

Merged
merged 1 commit into from
Feb 4, 2022
Merged

#84 Last to TakeLast #85

merged 1 commit into from
Feb 4, 2022

Conversation

meian
Copy link
Owner

@meian meian commented Feb 4, 2022 •
edited
Loading

Closes #84

What changed

  • Rename function Last to TakeLast
  • Rename relative tests.
    • No add new tests.

Others

Add any other context about pull request here.

Checklist

  • Issue is linked.
    • It is not needed if simple edit such as corrections of words, etc.
  • Test is added.
    • If fixed bug, add case on existing test or add new test.
    • If add new feature, add new test.
    • Add benchmark test, as needed.
  • Test coverage rate has no decreased.
    • If rate is decreased, explain why in What changed.

@meian meian added the improvement Some improvement label Feb 4, 2022
@meian meian self-assigned this Feb 4, 2022
@meian meian force-pushed the 84-last-to-takelast branch from 0fbbad0 to b407f5a Compare February 4, 2022 13:17
@meian meian marked this pull request as ready for review February 4, 2022 13:19
@meian meian merged commit d7eaa9d into main Feb 4, 2022
@meian meian deleted the 84-last-to-takelast branch February 4, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@meian meian

Labels
improvement Some improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Proposal]Last to TakeLast
1 participant
@meian