Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#86 Add test with 0 element but not empty #88

Merged
merged 2 commits into from
Feb 5, 2022
Merged

#86 Add test with 0 element but not empty #88

merged 2 commits into from
Feb 5, 2022

Conversation

meian
Copy link
Owner

@meian meian commented Feb 5, 2022 •
edited
Loading

Closes #86

What changed

  • Add empty but not emptyIterable test case.
  • Rename testEmptyChain to testEmpties
    • The timing of running the new test case is the same as the existing, so rename to be matched to both case.

Others

Checklist

  • Issue is linked.
    • It is not needed if simple edit such as corrections of words, etc.
  • Test is added.
    • If fixed bug, add case on existing test or add new test.
    • If add new feature, add new test.
    • Add benchmark test, as needed.
  • Test coverage rate has no decreased.
    • If rate is decreased, explain why in What changed.

@meian meian added the improvement Some improvement label Feb 5, 2022
@meian meian self-assigned this Feb 5, 2022
@meian meian force-pushed the 86-add-test-with-0-element-but-not-empty branch from a5d95b9 to cd6f5ea Compare February 5, 2022 06:15
@meian meian marked this pull request as ready for review February 5, 2022 06:19
@meian meian force-pushed the 86-add-test-with-0-element-but-not-empty branch from cd6f5ea to a5c3bcf Compare February 5, 2022 06:47
meian
meian commented Feb 5, 2022
View reviewed changes
common_test.go Outdated Show resolved Hide resolved
common_test.go Outdated Show resolved Hide resolved
@meian meian force-pushed the 86-add-test-with-0-element-but-not-empty branch from a5c3bcf to bab37dd Compare February 5, 2022 06:57
meian
meian commented Feb 5, 2022
View reviewed changes
common_test.go Show resolved Hide resolved
@meian meian force-pushed the 86-add-test-with-0-element-but-not-empty branch from b10d681 to bca0008 Compare February 5, 2022 07:01
@meian meian merged commit 397bc4b into main Feb 5, 2022
@meian meian deleted the 86-add-test-with-0-element-but-not-empty branch February 5, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@meian meian

Labels
improvement Some improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Proposal]Add test with 0 element but not empty
1 participant
@meian