Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept a function to abort the indexing process #86

Merged
merged 2 commits into from
Sep 28, 2024
Merged

Accept a function to abort the indexing process #86

merged 2 commits into from
Sep 28, 2024

Conversation

irevoire
Copy link
Member

@irevoire irevoire commented Aug 7, 2024 •
edited
Loading

Pull Request

To merge after #96

Related issue

Fixes #85

What does this PR do?

  • Add a new parameter in the Writer::build method that lets meilisearch abort the indexing process

@irevoire irevoire added enhancement New feature or request indexing Everything related to indexing labels Aug 7, 2024
@irevoire irevoire requested a review from dureuill August 7, 2024 14:10
@irevoire irevoire marked this pull request as draft September 25, 2024 16:45
@irevoire irevoire marked this pull request as ready for review September 26, 2024 08:47
Kerollmops
Kerollmops requested changes Sep 26, 2024
View reviewed changes
src/writer.rs Show resolved Hide resolved
@irevoire irevoire added this to the v0.4.0 milestone Sep 26, 2024
Kerollmops
Kerollmops approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you 😌

@Kerollmops Kerollmops merged commit e6dd6df into main Sep 28, 2024
8 checks passed
@Kerollmops Kerollmops deleted the abort-indexing-process branch September 28, 2024 09:28
@irevoire irevoire mentioned this pull request Sep 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

@dureuill dureuill Awaiting requested review from dureuill

Assignees
No one assigned
Labels
enhancement New feature or request indexing Everything related to indexing
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

Provide a way to abort the indexing process
2 participants
@irevoire @Kerollmops