-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflows to use github-issues-scraper after docs-scraper on deploy #404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all the settings set up to this repo? 🙂
fc0ad4c
to
48c2673
Compare
48c2673
to
e92e34b
Compare
Yes, I just added them! |
e92e34b
to
598ea2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve but it should be a draft since we cannot merge it because of the issue I'm fixing right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, I realize I don't really like the display for the GitHub results:
All the results are the same issue, except there are different comments. But the results do not bring new useful information: there are all the same information.
We use a distinctUrl
on url
field. It means if 2 results have the same url, it will only display the first one. But currently, all your URLs are unique because of the comments urls that look like this:
https://github.com/meilisearch/MeiliSearch/issues/655#issuecomment-636310981
I would like your github-issues-scraper to use url
only for the PR or issue url (https://github.com/meilisearch/MeiliSearch/issues/655
) and the anchor for the comment (issuecomment-636310981
).
I will adapt the code in this PR (for the front part) once you fixed that, if you agree with me @tpayet .
QuestionAre the closed PRs and issues added to MeiliSearch? 🙂 |
Where are we with this PR ? |
Any news about this PR? |
I changed the status to draft based on what you wrote @curquiza |
@meilisearch/docs-team has discussed this PR today and decided to close it. This is due to relevancy and usability reasons:
We are looking into a different solution for this problem which would involve taking the user to github issues only if no relevant results can be found on the docs. |
This PR add the github-issues-scraper run after docs-scraper during deploy of documentation.
It adds the ability to search through GitHub issues & PR of meilisearch/meilisearch from the documentation search bar.
The worklfow is almost done but I still have an issue regarding links that are not directing to GitHub