Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dotnet cli to publish nuget package #488

Merged

Conversation

kashifsoofi
Copy link
Contributor

Pull Request

Related issue

Fixes #480

What does this PR do?

  • use dotnet cli to publish nuget package

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@curquiza curquiza changed the title #480: Use dotnet cli to publish nuget package Use dotnet cli to publish nuget package Oct 12, 2023
@curquiza curquiza added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Oct 12, 2023
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's wooooooooorking! I created this empty release to check everything is fine, and it is, let's merge this PR!
https://github.com/meilisearch/meilisearch-dotnet/releases/tag/v0.14.5

bors merge

@curquiza
Copy link
Member

bors merge

1 similar comment
@curquiza
Copy link
Member

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Oct 12, 2023

Already running a review

@curquiza
Copy link
Member

bors merge

@curquiza
Copy link
Member

Looks like we have issues with bors, merging manually since this only impacts CI and not code base

@curquiza curquiza merged commit 97c6ab2 into meilisearch:main Oct 12, 2023
3 of 4 checks passed
@kashifsoofi kashifsoofi deleted the #480/repalce-publish-nuget-action branch October 13, 2023 09:40
@curquiza curquiza added the enhancement New feature or request label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace the GitHub action to publish to Nugget
2 participants