Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runtimeconfig #612

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Add runtimeconfig #612

merged 2 commits into from
Jan 21, 2025

Conversation

danFbach
Copy link
Contributor

Pull Request

Related issue

Fixes #605

What does this PR do?

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@curquiza curquiza added bug Something isn't working maintenance Anything related to maintenance (CI, tests, refactoring...) and removed bug Something isn't working labels Jan 21, 2025
curquiza
curquiza approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@curquiza curquiza changed the title add runtimeconfig Add runtimeconfig Jan 21, 2025
@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Jan 21, 2025

Build succeeded:

@meili-bors meili-bors bot merged commit 5f9549f into meilisearch:main Jan 21, 2025
4 checks passed
@danFbach danFbach deleted the runtimeconfig-json-fix-publish branch January 21, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Impossible to release the package to Nugget
2 participants
@danFbach @curquiza