Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MeilisearchException a RuntimeException #683

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Make MeilisearchException a RuntimeException #683

merged 1 commit into from
Nov 18, 2023

Conversation

junghoon-vans
Copy link
Contributor

Pull Request

Related issue

Fixes #677

What does this PR do?

  • Change MeilisearchException to extends RuntimeException.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

brunoocasali
brunoocasali approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your explanation of the issue! LGTM!

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Nov 18, 2023

Build succeeded:

  • integration-and-unit-tests
  • linter

@meili-bors meili-bors bot merged commit 2a937fd into meilisearch:main Nov 18, 2023
2 checks passed
@brunoocasali brunoocasali added the enhancement New feature or request label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make MeilisearchException as RuntimeException
2 participants
@junghoon-vans @brunoocasali