Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting the project to typescript #121

Closed
bidoubiwa opened this issue Nov 5, 2020 · 1 comment
Closed

Converting the project to typescript #121

bidoubiwa opened this issue Nov 5, 2020 · 1 comment
Labels
enhancement New feature or request instant-meilisearch

Comments

@bidoubiwa
Copy link
Contributor

Proposition

As this is a small project, converting it to typescript is a task that should not be that hard.

Benefits

If the project is in typescript, we can generate a typed.d.ts file containing all the types from this project. This file, in turn, would make this library available for TypeScript user.

More types mean fewer errors, an easier coding experience, and overall better readability of the code.

Cons

Adding typescript brings some complexity in configuration and requires more knowledge to maintain than a vanilla JS project.

Related to #118
@bidoubiwa bidoubiwa added the enhancement New feature or request label Nov 5, 2020
This was referenced Nov 5, 2020
Closed
Merged
@bidoubiwa
Copy link
Contributor Author

Implemented by: #249

@bidoubiwa bidoubiwa mentioned this issue Feb 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request instant-meilisearch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@curquiza @bidoubiwa