You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In preparation for #121 I tried running through the contributing guidelines, however, the step yarn lint was not running successfully on a fresh checkout. The commands given before that were fine.
yarn lint
yarn run v1.22.10
$ eslint --ext .js,.ts,.tsx .
Oops! Something went wrong! :(
ESLint: 7.12.1
ESLint couldn't find the config "react-app" to extend from. Please check that the name of the config is correct.
The config "react-app" was referenced from the config file in "/Users/bb/src/meilisearch/instant-meilisearch/playgrounds/react/package.json".
If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
After yarn add -D eslint-config-react-app, it still failed because of eslint-plugin-flowtype (and a few others) it runs... but it does not terminate, at least not within a few minutes:
$ yarn lint
yarn run v1.22.10
$ eslint --ext .js,.ts,.tsx .
Warning: React version was set to "detect" in eslint-plugin-react settings, but the "react" package is not installed. Assuming latest React version for linting.
It just keeps one core busy at 99% CPU.
I'm using node 14.14.0 and these are my changes compared to current master:
123: Add missing packages for yarn lint and upgrade all r=curquiza a=bb
Add packages for `yarn lint` and upgrade all packages. Might be fine to merge, if it doesn't break anything for you. It wasn't working for me before the changes either, so I can't test. See #124 for more information about my issues.
Co-authored-by: Benjamin Bock <bb--git.luolix.top@bock.be>
In preparation for #121 I tried running through the contributing guidelines, however, the step
yarn lint
was not running successfully on a fresh checkout. The commands given before that were fine.After
yarn add -D eslint-config-react-app
, it still failed because ofeslint-plugin-flowtype
(and a few others) it runs... but it does not terminate, at least not within a few minutes:It just keeps one core busy at 99% CPU.
I'm using node 14.14.0 and these are my changes compared to current master:
I also upgraded all outdated packages but it did not help. I created a PR to share the current WIP.
The text was updated successfully, but these errors were encountered: