Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn lint is not running #124

Closed
bb opened this issue Nov 5, 2020 · 2 comments
Closed

yarn lint is not running #124

bb opened this issue Nov 5, 2020 · 2 comments

Comments

@bb
Copy link
Contributor

bb commented Nov 5, 2020

In preparation for #121 I tried running through the contributing guidelines, however, the step yarn lint was not running successfully on a fresh checkout. The commands given before that were fine.

yarn lint
yarn run v1.22.10
$ eslint --ext .js,.ts,.tsx .

Oops! Something went wrong! :(

ESLint: 7.12.1

ESLint couldn't find the config "react-app" to extend from. Please check that the name of the config is correct.

The config "react-app" was referenced from the config file in "/Users/bb/src/meilisearch/instant-meilisearch/playgrounds/react/package.json".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

After yarn add -D eslint-config-react-app, it still failed because of eslint-plugin-flowtype (and a few others) it runs... but it does not terminate, at least not within a few minutes:

$ yarn lint
yarn run v1.22.10
$ eslint --ext .js,.ts,.tsx .
Warning: React version was set to "detect" in eslint-plugin-react settings, but the "react" package is not installed. Assuming latest React version for linting.

It just keeps one core busy at 99% CPU.

I'm using node 14.14.0 and these are my changes compared to current master:

--- a/package.json
+++ b/package.json
@@ -39,16 +39,23 @@
     "@babel/preset-env": "^7.10.4",
     "@rollup/plugin-commonjs": "^15.0.0",
     "@rollup/plugin-node-resolve": "^10.0.0",
+    "babel-eslint": "^10.1.0",
     "babel-jest": "^26.1.0",
     "eslint": "^7.5.0",
     "eslint-config-prettier": "^6.11.0",
+    "eslint-config-react-app": "^6.0.0",
     "eslint-config-standard": "^15.0.1",
+    "eslint-plugin-flowtype": "^5.2.0",
     "eslint-plugin-import": "^2.22.0",
     "eslint-plugin-jest": "^24.0.0",
+    "eslint-plugin-jsx-a11y": "^6.4.1",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-prettier": "^3.1.4",
     "eslint-plugin-promise": "^4.2.1",
+    "eslint-plugin-react": "^7.21.5",
+    "eslint-plugin-react-hooks": "^4.2.0",
     "eslint-plugin-standard": "^4.0.1",
+    "eslint-plugin-vue": "^7.1.0",
     "jest": "^26.1.0",
     "jest-watch-typeahead": "^0.6.0",
     "prettier": "2.1.1",

I also upgraded all outdated packages but it did not help. I created a PR to share the current WIP.

@bb
Copy link
Contributor Author

bb commented Nov 5, 2020

This issue will be solved when #123 is merged. See comments there for details.

bors bot added a commit that referenced this issue Nov 9, 2020
123: Add missing packages for yarn lint and upgrade all r=curquiza a=bb

Add packages for `yarn lint` and upgrade all packages. Might be fine to merge, if it doesn't break anything for you. It wasn't working for me before the changes either, so I can't test. See #124 for more information about my issues.

Co-authored-by: Benjamin Bock <bb--git.luolix.top@bock.be>
@curquiza
Copy link
Member

curquiza commented Nov 9, 2020

Close by #123 🚀

@curquiza curquiza closed this as completed Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants