Add missing packages for yarn lint and upgrade all #123
Conversation
|
As most times, the issue was quite obvious in hindsight. Lint was checking all files in node_modules and dist (also those in sub folders like examples/esm) because they were not ignored. The second commit improves that and thus also fixes #124. |
|
I added another commit which adds missing peer (dev-) dependencies: |
There was a problem hiding this comment.
Awesome!
Could you add a CI that tests this? You can change .github/workflows/test.yml and add the following job:
jobs:
style: instant-meilisearch-style-tests
name: nstant-meilisearch-style-tests
runs-on: ubuntu-latest
name: Tests style
run: yarn lintand inside ./bors.toml
Change this value:
status = ["instant-meilisearch-tests"]To this one:
status = ["instant-meilisearch-tests", "instant-meilisearch-style-tests"]
|
bors try |
|
🔒 Permission denied Existing reviewers: click here to make bb a reviewer |
|
@bidoubiwa I added the changes you requested (with slight syntax changes and added the yarn install step) in the text.yml but it doesn't look like it's running in the branch. I tried to trigger it but got permission denied. Can you please check? |
|
bors try |
tryMerge conflict. |
|
It seems to be failing because of a merge conflict. Could you rebase? |
There was a problem hiding this comment.
Your PR is really great @bb! 😁
The merge conflict is indeed due to all the package updates you've done in this PR.
As @bidoubiwa said, you need to rebase and fix the merge conflict at the same time. I don’t know if you are already on our Slack, feel free to joins us, it would be easier to discuss if you need help with the rebase (I’m Clementine). And we also have a #contributions channel if you are interested in MeiliSearch’s tools contributions in general!
bb
force-pushed
the
missing-lint-packages
branch
from
5987353
to
7d41838
Compare
|
Build succeeded: |
curquiza
added
the
skip-changelog
Add packages for
yarn lintand upgrade all packages. Might be fine to merge, if it doesn't break anything for you. It wasn't working for me before the changes either, so I can't test. See #124 for more information about my issues.