Fix "dynamic call to static method" phpstan error in tests #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure about this change, I think in phpunit v10 they are not static anymore,unless I am mistaken Edit: yes I'm wrong 🙈 |
norkunas
requested changes
Jan 21, 2024
|
I ended up adding 2 php-cs-fixer rules:
|
norkunas
requested changes
Jan 23, 2024
Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>
norkunas
approved these changes
Jan 23, 2024
|
bors merge |
meili-bors bot
added a commit
that referenced
this pull request
Jan 23, 2024
612: Fix "dynamic call to static method" phpstan error in tests r=norkunas a=aivchen # Pull Request ## What does this PR do? - replaces `$this->assertXXX` calls with `static::assertXXX` - replaces `assertEquals` calls with `assertSame` - ordered arguments in `assertSame` calls ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: andrew <and.ivchenkov@gmail.com> Co-authored-by: Andrew Ivchenkov <and.ivchenkov@gmail.com>
|
Build failed: |
|
bors merge |
|
Build succeeded:
|
|
Thank you @aivchen |
curquiza
added
the
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
$this->assertXXXcalls withstatic::assertXXXassertEqualscalls withassertSameassertSamecallsPR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!