Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ranking score threshold #644

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Add ranking score threshold #644

merged 1 commit into from
Jun 6, 2024

Conversation

the-sinner
Copy link
Contributor

Pull Request

Related issue

Fixes #641

What does this PR do?

  • Add ranking score threshold

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@the-sinner
Copy link
Contributor Author

@curquiza do you want changes for #642 in the same PR or in a different PR ?

@curquiza
Copy link
Member

curquiza commented Jun 6, 2024

Hello @the-sinner
In a different PR, thank you very much 🙏

@curquiza curquiza added the enhancement New feature or request label Jun 6, 2024
curquiza
curquiza approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much @the-sinner

@curquiza curquiza merged commit 9645ddf into meilisearch:bump-meilisearch-v1.9.0 Jun 6, 2024
7 of 11 checks passed
@curquiza curquiza linked an issue Jun 6, 2024 that may be closed by this pull request
[v1.9.0] Filter by ranking score #641
Closed
2 tasks
@curquiza curquiza mentioned this pull request Jun 6, 2024
Closed
2 tasks
norkunas pushed a commit to norkunas/meilisearch-php that referenced this pull request Jul 10, 2024
@the-sinner @norkunas
Add ranking score threshold (meilisearch#644)
ea780d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norkunas norkunas norkunas left review comments

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v1.9.0] Filter by ranking score
3 participants
@the-sinner @curquiza @norkunas