Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to run with PHP 8.4 #696

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Update CI to run with PHP 8.4 #696

merged 2 commits into from
Dec 4, 2024

Conversation

norkunas
Copy link
Collaborator

Pull Request

Related issue

Fixes #<issue_number>

What does this PR do?

  • ...

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@norkunas norkunas added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Nov 30, 2024
@norkunas norkunas requested a review from curquiza November 30, 2024 18:54
@norkunas norkunas force-pushed the ci branch 2 times, most recently from 9733990 to 5a2cc0d Compare November 30, 2024 18:56
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.15%. Comparing base (55dc98f) to head (c1740a4).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
+ Coverage   89.71%   90.15%   +0.44%     
==========================================
  Files          52       52              
  Lines        1322     1341      +19     
==========================================
+ Hits         1186     1209      +23     
+ Misses        136      132       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

molto bene!
thank youuu

bors merge

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@norkunas
Copy link
Collaborator Author

norkunas commented Dec 4, 2024

bors

@curquiza curquiza merged commit a1a414e into meilisearch:main Dec 4, 2024
34 of 35 checks passed
@norkunas norkunas deleted the ci branch December 4, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants