Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPStan 2 + fixed uninitialized properties in SearchResult #706

Merged
merged 2 commits into from
Dec 12, 2024
Merged

PHPStan 2 + fixed uninitialized properties in SearchResult #706

merged 2 commits into from
Dec 12, 2024
+36 −19

Conversation

aivchen
Copy link
Contributor

@aivchen aivchen commented Dec 11, 2024

What does this PR do?

  • new version of PHPStan
  • fixed errors reported by PHPStan
  • fixed a possible case when some properties could be accesses before initialization in SearchResult class

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.74%. Comparing base (43b0f45) to head (368c73f).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #706      +/-   ##
==========================================
+ Coverage   90.14%   90.74%   +0.59%     
==========================================
  Files          52       52              
  Lines        1340     1340              
==========================================
+ Hits         1208     1216       +8     
+ Misses        132      124       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@norkunas
Copy link
Collaborator

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Dec 12, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 20f68c7 into meilisearch:main Dec 12, 2024
35 checks passed
@norkunas
Copy link
Collaborator

Thank you @aivchen

@curquiza curquiza added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Dec 12, 2024
@Strift Strift mentioned this pull request Dec 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norkunas norkunas norkunas approved these changes

Assignees
No one assigned
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aivchen @norkunas @curquiza