Fix missing index_uid in clean up job (#352)

[ellnix]

Pull Request

Related issue

Fixes #352

[curquiza]

thanks @ellnix

bors merge

[meili-bors]

Build failed:

• integration-tests (Rails 6.1 with Ruby 3.0)

[curquiza]

I hate codecoverage, there is always something failing... 😅

[drale2k]

Hi, will this be merged?

[ellnix]

Hi, will this be merged?

I'm not familiar with Codecov (and don't have time to get familiar recently 🥲).

We have to wait for someone from Meilisearch staff who has the authority to merge this.

[curquiza]

Invoking @brunoocasali here 🙏

[brunoocasali]

I've regenerate the CODECOV_TOKEN let's see if that helps 😢

[curquiza]

bors merge

[meili-bors]

Build failed:

• integration-tests (Rails 6.1 with Ruby 3.0)

[curquiza]

@brunoocasali it still does not work 😢

[brunoocasali]

Hi @ellnix can you take a look at the failing tests? Maybe the codecov issue will be gone as soon as we fix the tests.

[ellnix]

Hi @ellnix can you take a look at the failing tests? Maybe the codecov issue will be gone as soon as we fix the tests.

@brunoocasali test regressions fixed, codecov is still bugging.

[brunoocasali]

Look what I found in the docs https://github.com/codecov/codecov-action?tab=readme-ov-file#usage

So, I replaced it to use the arg instead of the env, didn't work. Then I added both, didn't work, then I tried to create my own branch without the fork didn't work either.

But, I ran out of time to fix it, so I made a commit removing the codecov.

[brunoocasali]

Guess what? Even after removing the GithubAction, we still have the issue because we have an outdated version of the codec gem installed (I didn't remember we were using one).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (9f71936) to head (7c2465e).

❗ Current head 7c2465e differs from pull request most recent head 30d5ed0. Consider uploading reports for the commit 30d5ed0 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #353   +/-   ##
=======================================
  Coverage   90.22%   90.22%           
=======================================
  Files          13       13           
  Lines         757      757           
=======================================
  Hits          683      683           
  Misses         74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[brunoocasali]

bors merge