Create get_update fn to get one update status #133
Conversation
|
Thank you very much! I thought about this when I created the library but that wasn't the priority at this time. I really like your solution. I will take a deeper look and give a probably favorable review in the next few days. |
curquiza
changed the title
|
Hello @icyJoseph! Thanks a lot for your PR :) Could you update the code sample file with the new usage of the function? meilisearch-rust/.code-samples.meilisearch.yaml Lines 62 to 63 in 39aeac1 This file is used to generate the |
Will do! |
References the possiblity to get progress status directly on the progress object. Narrow down the use cases for `get_update`. On the `.code-samples.meilisearch.yaml` file, use two examples, one showing how to get the status on the progress object, and a second example showing how to get the update status from the index using the update_id. Also resolve other PR comments.
|
bors try |
tryBuild succeeded: |
|
What happened to the |
I removed this test from the settings, my bad 🙂 it was related to #138 that is not merged yet |
There was a problem hiding this comment.
I approve, but I wait for the @Mubelotix approval before any merge 🙂
Thanks again for this PR @icyJoseph
|
Awesome!! bors merge |
|
Build succeeded: |
Hi,
Having fun using this SDK, but I reckon a function to get the status of one single update is missing.
When I read through https://docs.meilisearch.com/reference/api/updates.html#get-an-update-status, I see for example:
Where the argument of
getUpdateStatus, I guess, is the update id based on what the cURL version does:curl \ -X GET 'http://localhost:7700/indexes/movies/updates/1'Which mirrors the MeiliSearch
/indexes/:index_uid/updates/:updateIdendpoint.The rather unlucky thing is that to do the same with the Rust SDK it is not sufficient, not possible, to use the update id.
The above requires access to the
progressinstance, which is not possible in my case. Regardless of any specific use case, it is my opinion that for completeness sake, theget_updatefunction, defined in this PR, is needed to complete the SDK. Of course this can be challenged, or perhaps there's a reason to why such function does not exist.Thanks for the SDK! Great Job!