Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature: dictionary settings #529

Merged

Conversation

hasan-raja
Copy link
Contributor

Pull Request

Related issue

Fixes #527

What does this PR do?

  • Added the dictionary setting to the Settings struct, providing users with a flexible way to manage their search dictionary.
  • Implemented three new methods for interacting with the dictionary setting:
    • get_dictionary: Retrieves the current dictionary configuration.
    • set_dictionary: Updates the dictionary with a new configuration.
    • reset_dictionary: Resets the dictionary configuration to default values.
  • Created comprehensive integration tests to ensure the correctness and robustness of these new methods.

PR checklist

Please check if your PR fulfills the following requirements:

  • Added integration tests for the new methods.
  • Verified the correctness of existing unit tests.
  • Ensured that the codebase adheres to the project's coding style guidelines.
  • Updated the .code-samples.meilisearch.yaml file to incorporate new examples for the get_dictionary, set_dictionary, and reset_dictionary methods.

Please review and provide feedback on the changes introduced in this pull request.

@curquiza curquiza added the enhancement New feature or request label Oct 11, 2023
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @hasan-raja

thanks a lot for your PR

looks the Ci rust-format is failing, otherwise the PR is good
can you fix it before I merge?

@hasan-raja
Copy link
Contributor Author

Hi @curquiza made an update based on rust format

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Oct 11, 2023

@meili-bors meili-bors bot merged commit f3f00f4 into meilisearch:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.4] Support user-dictionary loading
2 participants