Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecations #259

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Fix deprecations #259

merged 1 commit into from
Jun 9, 2023

Conversation

norkunas
Copy link
Collaborator

@norkunas norkunas commented Jun 9, 2023

Pull Request

Related issue

Fixes #258

What does this PR do?

  • Fixes deprecations

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@norkunas norkunas force-pushed the fix-deprecations branch 5 times, most recently from ddabe11 to 3196a9c Compare June 9, 2023 08:24
@norkunas norkunas force-pushed the fix-deprecations branch from 3196a9c to 3d9752d Compare June 9, 2023 08:28
brunoocasali
brunoocasali approved these changes Jun 9, 2023
View reviewed changes
src/EventListener/DoctrineEventSubscriber.php
use Doctrine\Persistence\Event\LifecycleEventArgs;
use Meilisearch\Bundle\SearchService;

final class DoctrineEventSubscriber implements EventSubscriber
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to implement this interface anymore? 👀

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, doctrine has listeners and in Symfony it's enough to tag the class with the appropriate event

tests/baseline-ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the stack expert here, you probably had reasons for skipping those warnings here, and I will agree with them. But I would like to have a process or at least know how to avoid those additions. Because to me, this kind of file only grows indefinitely.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it will be reduced later. There are some indirect deprecations that cannot be fixed and need to wait upstream fix

@brunoocasali
Copy link
Member

bors merge

@brunoocasali brunoocasali added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Jun 9, 2023
@meili-bors
Copy link
Contributor

meili-bors bot commented Jun 9, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit 1b16382 into meilisearch:main Jun 9, 2023
@meili-bot
Copy link
Contributor

This message is sent automatically

Thank you very much for submitting your PR! Did you know that throughout the month of June we’re holding a rafle?
If you share the link to your merged PR in our #giveaway Discord channel, you’ll automatically join a lottery for a chance at winning some Meiliswag. 🙂
Don’t hesitate to join us: https://discord.com/channels/1006923006964154428/1111273670657200198

@norkunas norkunas deleted the fix-deprecations branch June 9, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees
No one assigned
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecations needs to be fixed
3 participants
@norkunas @brunoocasali @meili-bot