Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test and deprecation #278

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Fix test and deprecation #278

merged 1 commit into from
Aug 8, 2023

Conversation

norkunas
Copy link
Collaborator

@norkunas norkunas commented Aug 4, 2023

Pull Request

Related issue

Fixes #<issue_number>

What does this PR do?

  • ...

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@norkunas norkunas force-pushed the fix-test branch 6 times, most recently from 814f872 to 798312d Compare August 4, 2023 05:26
@norkunas
Copy link
Collaborator Author

norkunas commented Aug 4, 2023

bors merge

meili-bors bot added a commit that referenced this pull request Aug 4, 2023
278: Fix test and deprecation r=norkunas a=norkunas

# Pull Request

## Related issue
Fixes #<issue_number>

## What does this PR do?
- ...

## PR checklist
Please check if your PR fulfills the following requirements:
- [ ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?


Co-authored-by: Tomas <norkunas.tom@gmail.com>
@meili-bors
Copy link
Contributor

meili-bors bot commented Aug 4, 2023

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@norkunas norkunas added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Aug 4, 2023
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@norkunas norkunas closed this Aug 8, 2023
@meili-bors meili-bors bot merged commit a15009f into meilisearch:main Aug 8, 2023
@norkunas norkunas deleted the fix-test branch August 8, 2023 17:12
@brunoocasali brunoocasali added the skip-changelog The PR will not appear in the release changelogs label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...) skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants