-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to configure custom http client #359
Conversation
dd8b48a
to
2c3080e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
============================================
+ Coverage 88.62% 88.67% +0.05%
Complexity 1 1
============================================
Files 20 20
Lines 897 901 +4
============================================
+ Hits 795 799 +4
Misses 102 102 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should add a section in the README to document the usage?
README doesn't have anything conf related, but we can add to the Wiki |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
@curquiza https://github.com/meilisearch/meilisearch-symfony/wiki/Http-Client not sure if I managed to properly explain |
Pull Request
Related issue
Fixes #357
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements: