General refactoring

[codedge]

This PR improves the code in various aspects

PHP version

Supported PHP versions are >=7.4 are >=8.0. Both, Symfony 4.4 and 5.0, can run using these versions.

Strict types

Using strict types is good. You know 😉

Type hints

By using PHP 7.4 as minimum version type hints can be set class properties. There are still places left in the code where multiple types are used or general object types. These place can (should?) be refactored at a later stage.

Comments

A lot of comments just describe the passed/parameter values and return values. Due to type hints they are obsolte.

Composer packages

The MeiliSearchImportCommand needs the Doctrine\Persistence\ManagerRegistry injected so Doctrine cannot only be a dev requirement.

I added the doctrine/orm package to the require section instead of require-dev.

This is also needed for the Symfony recipe PR I opened.

Tests

Some testing configuration seem to be unnecessary. I removed some configuration. Still, the tests run fine.

[curquiza]

@codedge thanks for your involvement and this refacto seems nice
Tell me when you think this is finished or if you want me to check something before continuing. I will check as soon as possible, but as you might have guessed with my abandoned PRs in this repo, I don't always have the time :) So your involvement on this repo is really helpful for me! Thanks again! 😁

If you are not already in our Slack, you can join us, it would be more convenient to discuss the PRs if needed: https://slack.meilisearch.com/

[codedge]

@curquiza Yep, saw your abandoned PRs and thought I could show some ❤️ to this repository.
I am going to fix the conflicts after we decided about the other open PRs that are left to be merged.

Joining Slack sound like a good plan. Already joined. 👍

[curquiza]

Hello @codedge, sorry for the delay!!!

It looks good to me 🙂
Can you just update the bors.toml file: removing the lines related to PHP 7.3 and 7.4 😇

Thanks again!

I've just gave you the write access to this repo: no need to work on your forked repo 🙂

[codedge]

@curquiza Fixed the integration tests. After this PR has been merged, I'll continue to work on the repo itself, without the forked repo. Let's just close this one here :) ... and thanks for the access 👍

[curquiza]

LGTM! Thanks again for your PR! And your help on this package 😁

bors merge

[bors]

Build succeeded:

• integration-tests (PHP 7.4)
• integration-tests (PHP 8.0)
• linter-check