This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Fix bug when inserting previously deleted documents #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
force-pushed
the
fix-dup-insert-after-delete
branch
from
7267e07
to
55b0ade
Compare
Kerollmops
changed the title
irevoire
reviewed
Jun 30, 2021
irevoire
reviewed
Jun 30, 2021
Kerollmops
force-pushed
the
fix-dup-insert-after-delete
branch
from
55b0ade
to
c92ef54
Compare
irevoire
approved these changes
Jun 30, 2021
|
Thank you @irevoire. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #268.
The issue was in the
ExternalDocumentsIdsimplementation in the specific case that an external document id was in the soft map marked as deleted.The bug was due to a wrong assumption on my side about how the FST unions were returning the
IndexedValues, I thought the values returned in an array were in the same order as the FSTs given to theOpBuilderbut in fact, theIndexedValue'sindexfield was here to indicate from which FST the values were coming from.