This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Remove limit of 1000 position per attribute #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManyTheFish
force-pushed
the
remove-max-position-per-attribute-limit
branch
4 times, most recently
from
c9719b8
to
131c0c9
Compare
3 tasks
ManyTheFish
force-pushed
the
remove-max-position-per-attribute-limit
branch
from
131c0c9
to
6506d63
Compare
irevoire
previously approved these changes
Oct 11, 2021
|
|
||
| // Compute the absolute word position with the field id of the attribute and relative position in the attribute. | ||
| pub fn absolute_from_relative_position(field_id: FieldId, relative: RelativePosition) -> Position { | ||
| (field_id as u32) << 16 | (relative as u32) |
There was a problem hiding this comment.
Me too! That's why I made tests!
irevoire
previously approved these changes
Oct 11, 2021
|
bors merge |
|
Merge conflict. |
Instead of using an arbitrary limit we encode the absolute position in a u32 using one strong u16 for the field id and a weak u16 for the relative position in the attribute.
ManyTheFish
force-pushed
the
remove-max-position-per-attribute-limit
branch
from
a70cba3
to
c5a6075
Compare
irevoire
approved these changes
Oct 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using an arbitrary limit we encode the absolute position in a u32
using one strong u16 for the field id and a weak u16 for the relative position in the attribute.
below is the database size difference for each dataset:
Related to product#202