This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Make charabia default feature optional #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @vincent-herlemont, Thanks! |
vincent-herlemont
force-pushed
the
make_charabia_feature_optional
branch
from
a1f2351
to
2884803
Compare
vincent-herlemont
force-pushed
the
make_charabia_feature_optional
branch
from
2884803
to
8cd5200
Compare
|
@ManyTheFish Sure commit here: 8cd5200 |
ManyTheFish
added
the
no breaking
ManyTheFish
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
Thank you @vincent-herlemont for your contribution! 👍
bors merge
ManyTheFish
added
maintenance
|
Build succeeded: |
bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Sep 21, 2022
2773: Allow building without specialized tokenizations r=Kerollmops a=jirutka Fixes #2774 (Some of) these specialized tokenizations include huge dictionaries that currently account for 90% (!) of the meilisearch binary size. This commit adds `chinese`, `hebrew`, `japanese`, and `thai` feature flags that are propagated via `milli` down to the `charabia` crate. To keep it backwards compatible, they are enabled by default. Related to meilisearch/milli#632 Co-authored-by: Jakub Jirutka <jakub@jirutka.cz>
bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Sep 21, 2022
2772: Improve issue template display to avoid support in Meilisearch issues r=curquiza a=curquiza Move the support line higher to make it more visible Like this: #2780 2773: Allow building without specialized tokenizations r=curquiza a=jirutka Fixes #2774 (Some of) these specialized tokenizations include huge dictionaries that currently account for 90% (!) of the meilisearch binary size. This commit adds `chinese`, `hebrew`, `japanese`, and `thai` feature flags that are propagated via `milli` down to the `charabia` crate. To keep it backwards compatible, they are enabled by default. Related to meilisearch/milli#632 Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com> Co-authored-by: Jakub Jirutka <jakub@jirutka.cz>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
Fixes #627
Thank you so much for contributing to Meilisearch!