-
Notifications
You must be signed in to change notification settings - Fork 81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. This looks good to me. It will also help us debug things :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you very much!
bors merge
Hey @GregoryConrad, Would it be possible to quickly fix the Clippy CI in a dedicated commit, please? |
Build succeeded:
|
Hi @Kerollmops, |
Hum... strange, it looks like the issue was in the filter-parser crate. Are you sure you use the latest version of Rust? i.e. |
@Kerollmops I still can't replicate: Would you mind copy-pasting the clippy output you have from |
Hey @GregoryConrad, sorry for the late reply. I just tried to trigger the Clippy error again and could not output it again 🎉 |
What does this PR do?
When embedding milli in an application (other than Meilisearch), it often makes sense to not use the
displayed_attributes
functionality and instead just use milli as a full document store. Thus, this PR adds a function,all_obkv_to_json
, to supplement the already exposedmilli::obkv_to_json
so that those embedding milli do not need to deal withdisplayed_attributes
if they don't need to.This PR also introduces a slight breaking change:(reverted in 935a724)obkv_to_json
now accepts a reference toobkv::KvReaderU16
instead of taking ownership of it. As far as I can tell, this seems like a change for the better (obkv_to_json
only acts uponobkv
rather than consuming it), but I can change it back if you so desire.PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!