-
Notifications
You must be signed in to change notification settings - Fork 81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @amab8901, I hope your next contribution will be easier 😂
bors merge
haha I don't mind that it's hard. Getting stuck and then getting shown how to get unstuck is very educational and gives me valuable experience. |
Also, just as a tip, when I contribute to an external repository, what I do is create two remotes. And then, when I want to make a new PR, I create a new branch with And if I need to update my repo / keep it in sync with the forked repository, I come back on main, Hope that helps with your future contribution! 🎉 |
722: Geosearch for zero radius r=irevoire a=amab8901 # Pull Request ## Related issue Fixes #3167 (meilisearch/meilisearch#3167) ## What does this PR do? - allows Geosearch with zero radius to return the specified location when the coordinates match perfectly (instead of returning nothing). See link for more details. - new attempt on #713 ## PR checklist Please check if your PR fulfills the following requirements: - [ X ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [ X ] Have you read the contributing guidelines? - [ X ] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: amab8901 <amab8901@protonmail.com> Co-authored-by: Tamo <irevoire@protonmail.ch>
Pull Request
Related issue
Fixes #3167 (meilisearch/meilisearch#3167)
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!