Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 💄 august #50

Merged
merged 21 commits into from
Aug 12, 2023
Merged

refactor: 💄 august #50

merged 21 commits into from
Aug 12, 2023

Conversation

melMass
Copy link
Owner

@melMass melMass commented Aug 5, 2023

  • Switch from my custom BOOL type to the comfy's BOOLEAN one since now there is builtin support for convertible widgets (comfyanonymous/ComfyUI@9534f0f) - Still need more testing.

  • Remove the Prores node and replace it with a more general ffmpeg streaming node.

  • Use PIL for GIF and not ffmpeg (better quality / filesize overall)

  • Improve Animation Builder's UX

  • Add a curve widget on the Fit Number node to interpolate the value, if too complex, at least start with a preselection of easing methods (https://easings.net/):
    easing_fit

  • Add "F.pad" to Transform Image:
    transform_image
    Screenshot 2023-08-12 234844

  • Fix the web install, I received many reports either through issues or DM about that. (cc Face Swap (MTB) #42 (reply in thread))

  • Refactor which classes are in which file, some stuff are still messy

melMass added 4 commits August 5, 2023 13:08
Since this commit:
comfyanonymous/ComfyUI@9534f0f

Input <-> widget is possible on booleans.
Locally I edited it but forgot about it not being in comfy

This commit is reversable since I'm not yet sure of all the impacts
melMass added 2 commits August 9, 2023 14:33
Will allow to install missing deps/models from the endpoint:
/mtb/status
@melMass melMass mentioned this pull request Aug 10, 2023
@melMass melMass merged commit 2ecd470 into main Aug 12, 2023
@melMass melMass deleted the dev/august-refactor branch August 12, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant