Update Carousel.js #419
Closed
Update Carousel.js #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this._previousItemsLength should be updated after the condition calling this._hackActiveSlideAnimation(). Currently the condition is never met.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android as far as I know.
What does this PR do?
this._hackActiveSlideAnimation()is never called.this._previousItemsLengthshould be updated after calling the condition that callsthis._hackActiveSlideAnimation(). Currently the condition is never met.What testing has been done on this change?
Tested features checklist
enableMomentum)vertical)activeSlideAlignment)autoplay)loop)ScrollView/FlatListcarousels (propuseScrollView)ParallaxImagecomponentPaginationcomponent