Implement brightness regulation for T-Display S3 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync Development Branch
melkati
reviewed
Mar 13, 2024
melkati
reviewed
Mar 13, 2024
There was a problem hiding this comment.
Please, adjust also the preferences initialization to initialize DisplayBrightness to 10 (for example, the value you think is better) when compiling for LILYGO_T_DISPLAY_S3.
Something like:
#ifdef LILYGO_T_DISPLAY_S3
DisplayBrightness = preferences.getUInt("DisplayBright", 10);
#else
DisplayBrightness = preferences.getUInt("DisplayBright", 100);
#endif
…ault preferences to value 8
melkati
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added funtionality to brightness regulation for T-Display S3 about your TODO roadmap:
https://github.com/users/melkati/projects/3/views/1?pane=issue&itemId=52285771