Fix Clang CI #124
Merged
Fix Clang CI #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM_ENABLE_RUNTIMES
wx257osn2
force-pushed
the
fix-clang-16-and-later
branch
from
5d46b2a to
c1ad403
Compare
|
descriptionとドキュメントよく読んだら |
melpon
reviewed
Apr 6, 2023
| @@ -20,8 +20,16 @@ if compare_version "$VERSION" ">=" "14.0.0"; then | |||
| pushd build | |||
| export CC=clang | |||
| export CXX=clang++ | |||
| LLVM_ENABLE_PROJECTS="clang;clang-tools-extra" | |||
| LLVM_ENABLE_RUNTIMES="" | |||
There was a problem hiding this comment.
これらの初期値は <16 としても >=16 としても間違ってる値だし、LLVM_ENABLE_RUNTIMES だけ -DLLVM_ENABLE_RUNTIMES= が付いてるのも分かりにくいので、
LLVM_ENABLE_PROJECTS="-DLLVM_ENABLE_PROJECTS=clang;clang-tools-extra;libcxx;libcxxabi"
LLVM_ENABLE_RUNTIMES=""
とした上で、>=16 だった場合に両方を書き換えたほうが分かりやすいです。
ga-build/clang/run.sh
Outdated
| @@ -20,8 +20,16 @@ if compare_version "$VERSION" ">=" "14.0.0"; then | |||
| pushd build | |||
| export CC=clang | |||
| export CXX=clang++ | |||
| LLVM_ENABLE_PROJECTS="clang;clang-tools-extra" | |||
There was a problem hiding this comment.
何でこういう分岐をしてるのかのコメントを残しておいて貰えると（この PR へのリンクでも良いです）
|
良さそう。修正ありがとうございます。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm-project16.0.0以降はlibcxxやlibcxxabiをLLVM_ENABLE_PROJECTSとして指定できないようです… 🙇