Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Popover overlay #1025

Merged
merged 5 commits into from
Mar 3, 2024
Merged

feat: Popover overlay #1025

merged 5 commits into from
Mar 3, 2024

Conversation

huntabyte
Copy link
Member

@huntabyte huntabyte commented Feb 29, 2024

This PR adds an (optional) overlay element builder to the Popover to enable modal behavior. To simplify the review process, I'll create separate PRs to add this functionality to the other floating builders and once they are all merged/released will close #1023

It will be portalled to the same destination as the content.

Copy link

changeset-bot bot commented Feb 29, 2024

🦋 Changeset detected

Latest commit: 23e269d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@melt-ui/svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 29, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
melt-ui ✅ Ready (View Log) Visit Preview 23e269d

@TGlide
Copy link
Member

TGlide commented Mar 3, 2024

Added a comment in #1023

@huntabyte huntabyte merged commit 162fda1 into melt-ui:develop Mar 3, 2024
5 checks passed
@huntabyte huntabyte deleted the feat/overlays branch March 3, 2024 22:25
@github-actions github-actions bot mentioned this pull request Mar 3, 2024
lolcabanon pushed a commit to lolcabanon/melt-ui that referenced this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Overlays for all modal-like builders
2 participants