-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controlled openFocus
& closeFocus
props
#663
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f8f6d89 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…nto controlled-autofocus
TGlide
requested changes
Oct 25, 2023
TGlide
approved these changes
Oct 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new props,
openFocus
, andcloseFocus
to a few of the builders where you might want to override how we handle focus on open and close.They accept a
FocusProp
type, which looks like this:Whatever is returned from this function will be focused instead of our default behavior. If
null
is passed, we don't focus on anything and expect you to handle it outside of the builder altogether.We provide the
defaultEl
argument as a fallback mechanism, which could be implemented like so:In this scenario, if we aren't able to select our custom element, we'll fall back to the default, ensuring we keep the a11y box checked.
The following builders have both the
openFocus
andcloseFocus
props:These builders only have the
closeFocus
:createMenu
returned from the Menubar)This PR also removes the need for the
disableTriggerRefocus
prop added to the menus in a previous PR.