feat: Add GtheSheep variant tap-contentful #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GtheSheep
requested review from
sbalnojan,
tayloramurphy and
pnadolny13
as code owners
👷 Deploy request for meltano-hub pending review.Visit the deploys page to approve it
|
|
@GtheSheep this is fantastic! What do you think about making this the default variant? I'm sure you looked at the existing variant so you'd probably know better but it looks like its very outdated and the settings arent even fully listed. I'd vote to make yours the default. |
|
Hey @pnadolny13 - happy to! tbh I never got past installing the other one (it failed), and didn't look much into whether that was just a outdated package thing or a compatibility with Meltano thing, so reached straight for the SDK 😅 |
pnadolny13
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.