ci: Use Ruff to lint project #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
force-pushed
the
1242-feature-lint-code-with-ruff
branch
from
d8ea33c
to
1525d76
Compare
Codecov Report
@@ Coverage Diff @@
## main #1462 +/- ##
=======================================
Coverage 85.46% 85.46%
=======================================
Files 57 57
Lines 4760 4760
Branches 809 809
=======================================
Hits 4068 4068
Misses 501 501
Partials 191 191
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
edgarrmondragon
force-pushed
the
1242-feature-lint-code-with-ruff
branch
2 times, most recently
from
e8d9cd5
to
e0feb44
Compare
edgarrmondragon
requested review from
a team,
tayloramurphy,
cjohnhanson and
aaronsteers
as code owners
- Auto-fixed unused imports (F401) - Fixed some unused variables and redefined test functions - Fixed docstring conventions in `singer_sdk/helpers/_state.py` - Fixed some imports and removed `isort` from pre-commit Can't get rid of flake8 entirely yet due to astral-sh/ruff#2459
edgarrmondragon
force-pushed
the
1242-feature-lint-code-with-ruff
branch
from
e0feb44
to
2029dd8
Compare
aaronsteers
reviewed
Mar 1, 2023
aaronsteers
approved these changes
Mar 1, 2023
WillDaSilva
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a few Ruff checks without being too aggressive. We can add more rules progressively.
In the meantime:
singer_sdk/helpers/_state.pyisortfrom pre-commitCan't get rid of flake8 entirely yet due to astral-sh/ruff#458
Closes #1242
📚 Documentation preview 📚: https://meltano-sdk--1462.org.readthedocs.build/en/1462/