Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exit code flag #77

Merged
merged 5 commits into from
Oct 25, 2019
Merged

Add exit code flag #77

merged 5 commits into from
Oct 25, 2019

Conversation

kakkoyun
Copy link
Contributor

@kakkoyun kakkoyun commented Oct 20, 2019

This PR adds a new parameter to API to ensure plugin fails for any type of error.
This is a hidden convenience flag to test the plugin in a container.

Fixes #58

Proposed Changes

  • Adds --exit-code flag
  • Fixes duplicate flag error introduced by feature: backend sftp #68 changes
  • Adds a new pipeline step to the drone flow, to dogfood our own pipeline.

Description

  • This PR adds a new parameter to API to ensure plugin fails for any type of error.
    This is a hidden convenience flag to test the plugin in a container.

Checklist

  • Read the CONTRIBUTING document.
  • Read the CODE OF CONDUCT document.
  • Add tests to cover changes.
  • Ensure your code follows the code style of this project.
  • Ensure CI and all other PR checks are green OR
    • Code compiles correctly.
    • Created tests which fail without the change (if possible).
    • All new and existing tests passed.
  • Add your changes to Unreleased section of CHANGELOG.
  • Improve and update the README (if necessary).
  • Ensure documentation is up-to-date. The same file will be updated in plugin index when your PR is accepted, so it will be available for end-users at http://plugins.drone.io.

@kakkoyun kakkoyun changed the title Exit code Add exit code flag Oct 20, 2019
@@ -319,7 +325,7 @@ func main() {
EnvVar: "SFTP_HOST",
},
cli.StringFlag{
Name: "sftp-host",
Name: "sftp-port",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the reviewer: This minor issue has introduced by the previous PR.

@@ -51,6 +51,37 @@ steps:
environment:
CGO_ENABLED: 0

- name: release-snapshot-dev
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the reviewer: These newly added steps ensure dev tagged container up-to-date. That particular container is used to test the plugin on its on CI pipeline.

@kakkoyun
Copy link
Contributor Author

@limayekaiwalya Have you had a chance to check this one?

@limayekaiwalya
Copy link
Collaborator

Not Yet @kakkoyun, I'll take a look tomorrow if that's okay.

@kakkoyun
Copy link
Contributor Author

Hey @limayekaiwalya, I have a huge PR coming up, in order to prevent any merge conflicts, I'm going to go ahead and merge this one if you find any issues, please still comment and I'll address them in another PR.

@kakkoyun kakkoyun merged commit 899b1d6 into meltwater:master Oct 25, 2019
@kakkoyun kakkoyun deleted the exit_code branch October 25, 2019 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --exit-code parameter
2 participants