-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exit code flag #77
Conversation
@@ -319,7 +325,7 @@ func main() { | |||
EnvVar: "SFTP_HOST", | |||
}, | |||
cli.StringFlag{ | |||
Name: "sftp-host", | |||
Name: "sftp-port", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the reviewer: This minor issue has introduced by the previous PR.
@@ -51,6 +51,37 @@ steps: | |||
environment: | |||
CGO_ENABLED: 0 | |||
|
|||
- name: release-snapshot-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the reviewer: These newly added steps ensure dev
tagged container up-to-date. That particular container is used to test the plugin on its on CI pipeline.
@limayekaiwalya Have you had a chance to check this one? |
Not Yet @kakkoyun, I'll take a look tomorrow if that's okay. |
Hey @limayekaiwalya, I have a huge PR coming up, in order to prevent any merge conflicts, I'm going to go ahead and merge this one if you find any issues, please still comment and I'll address them in another PR. |
This PR adds a new parameter to API to ensure plugin fails for any type of error.
This is a hidden convenience flag to test the plugin in a container.
Fixes #58
Proposed Changes
--exit-code
flagDescription
This is a hidden convenience flag to test the plugin in a container.
Checklist
Unreleased
section of CHANGELOG.