Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Alibaba oss backend setup #78

Closed
wants to merge 4 commits into from
Closed

Initial Alibaba oss backend setup #78

wants to merge 4 commits into from

Conversation

rugwirobaker
Copy link

@rugwirobaker rugwirobaker commented Oct 21, 2019 •
edited
Loading

Fixes #65

Proposed Changes

  • add github.com/aliyun/aliyun-oss-go-sdk/oss dependency.
  • Implement Alibaba Object Storage Service backend.
  • Add Alibaba OSS to plugins config

Description

Checklist

  • Read the CONTRIBUTING document.
  • Read the CODE OF CONDUCT document.
  • Add tests to cover changes.
  • Ensure your code follows the code style of this project.
  • Ensure CI and all other PR checks are green OR
    • [x ] Code compiles correctly.
    • Created tests which fail without the change (if possible).
    • All new and existing tests passed.
  • Add your changes to Unreleased section of CHANGELOG.
  • Improve and update the README (if necessary).
  • Ensure documentation is up-to-date. The same file will be updated in plugin index when your PR is accepted, so it will be available for end-users at http://plugins.drone.io.

@kakkoyun kakkoyun added storage-backend New storage backends WIP Work in progress do not merge labels Oct 21, 2019
@kakkoyun
Copy link
Contributor

kakkoyun commented Nov 1, 2019

Hey @rugwirobaker, I will try to give this one a push this weekend or in the next week.

What's left? Do you need help with something specific?

@kakkoyun kakkoyun changed the title [WIP]Initial alibaba oss backend setup Initial Alibaba oss backend setup Feb 7, 2020
@kakkoyun
Copy link
Contributor

kakkoyun commented Feb 7, 2020

Hey @rugwirobaker, any update on this?

@kakkoyun kakkoyun added the v1.2.0 Issues for v1.2.0 release label Feb 7, 2020
@rugwirobaker
Wrap up alibaba backend
4848fd8 
* add encryption option in the put method.
* wrap all errors.
* update initializeBackend function.
@rugwirobaker
Copy link
Author

@kakkoyun sorry I have been busy with other commitments. Just came back to it. Would actually appreciate help regarding testing since there all on integration tests in the backend package I assume you have to create an account with the corresponding backend service and live test? And of course documentation.

@kakkoyun
Copy link
Contributor

@rugwirobaker Happy to help. I've been working on a major refactoring after a couple of backends merged, in the same PR I'll be introducing an easy way to test backends. #86

I'll ping you when it's merged if you still want to continue working on it.

@rugwirobaker
Copy link
Author

I'm actually working on it right now. Just have to comply with the linter and we are go.

@rugwirobaker
Copy link
Author

@kakkoyun do you have any ideas on whether are alibaba-oss emulators that we can easly install into the dev/test environment? I'm thinking something like azurite.

@kakkoyun
Copy link
Contributor

@rugwirobaker I found this https://github.com/aliyun/oss-emulator from their official documentation https://www.alibabacloud.com/help/doc-detail/44075.html Unfortunately documentation in Chinese, however, code itself is readable. Also, there are some docker images https://hub.docker.com/search?q=oss-emulator&type=image It should work if we can figure how to run it.

What do you think?

@kakkoyun
Copy link
Contributor

kakkoyun commented Apr 8, 2020

@rugwirobaker We have changed overall structure, you may want to have a look at the latest state of master. It'd make more sense to check out a new branch and apply your changes rather than reading it.

@kakkoyun
Copy link
Contributor

@rugwirobaker Any plans to push this to the finish line?

@rugwirobaker
Copy link
Author

@kakkoyun I'm working on it this weekend. Should have something by Sunday.

@kakkoyun
Copy link
Contributor

@rugwirobaker Amazing news! Go for it

@kakkoyun
Copy link
Contributor

kakkoyun commented Feb 2, 2021

Hey @rugwirobaker, do you still think we can do this?

@bdebyl
Copy link
Contributor

bdebyl commented Jul 19, 2022

@rugwirobaker is this still a desired addition to drone cache, or anyone else want to take ownership? Otherwise I will most likely close the pull request due within the coming weeks.

@bdebyl
Copy link
Contributor

bdebyl commented Sep 13, 2022

Solved by #223

@bdebyl bdebyl closed this Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun Awaiting requested review from kakkoyun

@limayekaiwalya limayekaiwalya Awaiting requested review from limayekaiwalya

@seandtaber seandtaber Awaiting requested review from seandtaber seandtaber is a code owner

Assignees
No one assigned
Labels
do not merge storage-backend New storage backends v1.2.0 Issues for v1.2.0 release WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Alibaba OSS Storage Backend
3 participants
@rugwirobaker @kakkoyun @bdebyl