-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compression level CLI option #84
Conversation
Fixes meltwater#72 - Refactor Makefile - Remove test script in favor of Makefile - Automate usage generation - Upgrade Golangci-lint Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
@limayekaiwalya It's a long but a good one. Please take your time. |
@kakkoyun , Looking at it. Sorry for the long response times. I am taking a bit longer to understand the existing code so I can provide better reviews :) |
@limayekaiwalya Please tell me if you need anything to understand the existing codebase, happy to help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@kakkoyun A questions out of curiosity: Why did we switch to |
@limayekaiwalya The real change is about |
This PR adds compression level CLI option.
Also piggybacks a lot of refactorings. (sorry for lengthy PR)
Fixes #72
Proposed Changes
Description
Users now can specify compression level.
Checklist
Unreleased
section of CHANGELOG.