Add Azure Storage Backend #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacentropy
requested review from
kakkoyun,
limayekaiwalya and
seandtaber
as code owners
|
@spacentropy Wow. This looks great at a first glimpse. Thank you very much. |
|
Thanks. Let me green the build first, there are multiple linter errors :( I didn't use golangci-lint. Sorry for that, will fix now. |
kakkoyun
approved these changes
Feb 7, 2020
| @@ -2,7 +2,7 @@ | |||
| date: 2019-03-19T00:00:00+00:00 | |||
| title: Drone Cache | |||
| author: meltwater | |||
| tags: [ cache, amazon, aws, s3, volume ] | |||
| tags: [ cache, amazon, aws, s3, azure, volume ] | |||
There was a problem hiding this comment.
Suggested change
| tags: [ cache, amazon, aws, s3, azure, volume ] | |
| tags: [ cache, amazon, aws, s3, azure, blob, volume, storage ] |
| @@ -354,6 +354,15 @@ bucket | |||
| region | |||
| : AWS bucket region. (`us-east-1`, `eu-west-1`, ...) | |||
|
|
|||
| account_name | |||
There was a problem hiding this comment.
Let's add prefixes to these. We don't add prefixes to AWS ones to be back-compatible.
There was a problem hiding this comment.
You actually add the azure prefix we just need to update here in docs.
| func (c *azureBackend) Put(p string, src io.ReadSeeker) error { | ||
| blobURL := c.containerURL.NewBlockBlobURL(p) | ||
|
|
||
| fmt.Printf("uploading the file with blob name: %s\n", p) |
There was a problem hiding this comment.
You should use log, or remove this one. If you don't have logger available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62
Proposed Changes
Description
I just added Azure blob storage backend.
Checklist
Unreleasedsection of CHANGELOG.