Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase linter grade to 10.0 #107

Closed
melvio opened this issue Sep 19, 2021 · 2 comments · Fixed by #149
Closed

Increase linter grade to 10.0 #107

melvio opened this issue Sep 19, 2021 · 2 comments · Fixed by #149
Assignees
Labels
code-quality Code improvements without (big) semantic changes documentation Improvements or additions to documentation enhancement New features or semantic improvements good first issue Good for newcomers

Comments

@melvio
Copy link
Owner

melvio commented Sep 19, 2021

Currently, only the following lint errors exists:

$ pylint $(find src/ -name "*.py") --rcfile=./.github/workflows/pylintrc.conf
************* Module hopla.cli.config
src/hopla/cli/config.py:54:1: W0511: TODO: get_user this value from the HoplaDefaultConfiguration class instead of duplicating it here (fixme)
************* Module hopla.cli.get_user.auth
src/hopla/cli/get_user/auth.py:25:1: W0511: TODO: probably better to remove profilename here regardless (fixme)
************* Module hopla.hoplalib.configuration
src/hopla/hoplalib/configuration.py:108:5: W0511: TODO: this would be nicely testable (fixme)
************* Module hopla.hoplalib.authorization
src/hopla/hoplalib/authorization.py:165:13: W0511: TODO: handle this better: (fixme)

These are all relatively low prio (fixme) errors.

Proposed solution:

  • Instead of using the code as issue tracker, put these issues on github instead.
  • Bump the minimal linting score to 10.0
  • Change the Makefile to turn make test from && to ; make lint ; make unittest
    • That way, locally, you can run tests while violating the linter for a few minutes.
@melvio melvio added code-quality Code improvements without (big) semantic changes documentation Improvements or additions to documentation enhancement New features or semantic improvements good first issue Good for newcomers labels Sep 19, 2021
@melvio
Copy link
Owner Author

melvio commented Sep 27, 2021

@melvio melvio self-assigned this Sep 27, 2021
@melvio melvio added this to the Code Coverage >= 70% milestone Sep 27, 2021
@melvio melvio linked a pull request Sep 27, 2021 that will close this issue
@melvio
Copy link
Owner Author

melvio commented Sep 27, 2021

Decided against changing the Makefile.
Keeping code clean is a good idea, and you can always run make unitttest if you just want to run the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Code improvements without (big) semantic changes documentation Improvements or additions to documentation enhancement New features or semantic improvements good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant