Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor hopla authorization #146

Closed
melvio opened this issue Sep 27, 2021 · 2 comments
Closed

Refactor hopla authorization #146

melvio opened this issue Sep 27, 2021 · 2 comments
Labels
code-quality Code improvements without (big) semantic changes hopla-authenticate hopla authorization command low-priority

Comments

@melvio
Copy link
Owner

melvio commented Sep 27, 2021

Currently, way too much code is used for something simple.
This has to do with the migration from bash.
Now we use a different config file format, for which python has a lot of support. Use that instead.
@melvio melvio added code-quality Code improvements without (big) semantic changes hopla-authenticate hopla authorization command low-priority labels Sep 27, 2021
@melvio
Copy link
Owner Author

melvio commented Sep 27, 2021 •
edited
Loading

Marked it low-prio. It works as intended. And it nicely separated from the rest of the code base.

Mostly it is in authorization.py

@melvio melvio mentioned this issue Sep 27, 2021
Closed
@melvio
Copy link
Owner Author

melvio commented Sep 27, 2021

similar issue for config: #147

@melvio melvio closed this as not planned Won't fix, can't repro, duplicate, stale Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality Code improvements without (big) semantic changes hopla-authenticate hopla authorization command low-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@melvio